Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18674 )
Change subject: [threadpool] Fix scheduler thread a coredump bug ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/18674/4/src/kudu/util/threadpool.cc File src/kudu/util/threadpool.cc: http://gerrit.cloudera.org:8080/#/c/18674/4/src/kudu/util/threadpool.cc@154 PS4, Line 154: while (true) { : Status s = token->Submit(task.f); : if (s.ok()) { : break; : } : if (s.IsServiceUnavailable()) { : if (!token->MaySubmitNewTasks()) { : break; : } : // If capacity full, retry submit the task again, generally not reach the branch. : VLOG(1) << Substitute("threadpool token Submit status: $0", s.ToString()); : SleepFor(MonoDelta::FromMicroseconds(1)); : } else { : DCHECK(false) << Substitute("threadpool token Submit status: $0", s.ToString()); : } : } This looks a bit fishy to me. I'd expect that the outer loop with 'shutdown_' would handle this as needed, no? -- To view, visit http://gerrit.cloudera.org:8080/18674 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie5bc5511a745f3dc12dfe1a6a1813ece41ccc2a8 Gerrit-Change-Number: 18674 Gerrit-PatchSet: 4 Gerrit-Owner: Yuqi Du <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 29 Jun 2022 15:27:31 +0000 Gerrit-HasComments: Yes
