Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18562 )
Change subject: KUDU-2671 support creating table with custom hash schema per range ...................................................................... Patch Set 10: (2 comments) http://gerrit.cloudera.org:8080/#/c/18562/9/java/kudu-client/src/main/java/org/apache/kudu/client/CreateTableOptions.java File java/kudu-client/src/main/java/org/apache/kudu/client/CreateTableOptions.java: http://gerrit.cloudera.org:8080/#/c/18562/9/java/kudu-client/src/main/java/org/apache/kudu/client/CreateTableOptions.java@200 PS9, Line 200: > nit: missing indentation Done http://gerrit.cloudera.org:8080/#/c/18562/10/java/kudu-client/src/main/java/org/apache/kudu/client/PartitionPruner.java File java/kudu-client/src/main/java/org/apache/kudu/client/PartitionPruner.java: http://gerrit.cloudera.org:8080/#/c/18562/10/java/kudu-client/src/main/java/org/apache/kudu/client/PartitionPruner.java@175 PS10, Line 175: final List<PartitionSchema.HashBucketSchema> hashBucketSchemas = : partitionSchema.getHashSchemaForRange(rangeLowerBound); As I found out, here it's necessary to be more discreet w.r.t. hash schemas involved across the whole scan range: it's necessary to find a proper hash schema for every respective sub-range of the scan range, not just look at the beginning of the scan range. I'm planning to post an update on this soon. -- To view, visit http://gerrit.cloudera.org:8080/18562 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5ccf77ea2c39808520e76351d62571d449d10894 Gerrit-Change-Number: 18562 Gerrit-PatchSet: 10 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Comment-Date: Wed, 29 Jun 2022 16:51:34 +0000 Gerrit-HasComments: Yes
