Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18680 )
Change subject: [Partition] Make range partition to support senmatic: if not exist ...................................................................... Patch Set 1: Code-Review-1 (3 comments) http://gerrit.cloudera.org:8080/#/c/18680/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/18680/1//COMMIT_MSG@7 PS1, Line 7: senmatic You meant 'semantic', I guess? http://gerrit.cloudera.org:8080/#/c/18680/1//COMMIT_MSG@8 PS1, Line 8: : Currently, if a partition which already existed is added into a table, : it will get an error returned. And if two duplicated partitions are added : into a table, it also get an error returned. OK, so what's the problem then in analyzing the error code? http://gerrit.cloudera.org:8080/#/c/18680/1//COMMIT_MSG@13 PS1, Line 13: It is better to support senmatic "if not exist". It will be ignored when : add a existed or duplicated partition. I don't think this is a good idea. What if the requested partition to be added had a hash schema which differs from the hash schema of the existing one? -- To view, visit http://gerrit.cloudera.org:8080/18680 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icd403592ecfa137f774fada132f7ba46ce6071e4 Gerrit-Change-Number: 18680 Gerrit-PatchSet: 1 Gerrit-Owner: Wang Xixu <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 29 Jun 2022 17:00:56 +0000 Gerrit-HasComments: Yes
