Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18589 )
Change subject: [java] KUDU-2671 support adding a range with custom hash schema ...................................................................... Patch Set 8: (1 comment) http://gerrit.cloudera.org:8080/#/c/18589/7/java/kudu-client/src/main/java/org/apache/kudu/client/AlterTableOptions.java File java/kudu-client/src/main/java/org/apache/kudu/client/AlterTableOptions.java: PS7: > Any specific reason we are not checking if the schemas on the lowerBound an I guess the reason is that the check is performed in the constructor of the RangePartition class (the parent class): Preconditions.checkArgument(lowerBound.getSchema().equals(upperBound.getSchema())); -- To view, visit http://gerrit.cloudera.org:8080/18589 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ieaab7a79d4336de7ff6ec84b8c1806407e4fa44e Gerrit-Change-Number: 18589 Gerrit-PatchSet: 8 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Comment-Date: Fri, 01 Jul 2022 04:26:51 +0000 Gerrit-HasComments: Yes
