Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18715 )
Change subject: KUDU-2671 fix consistency check in KuduScanner::NextBatch() ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/18715/2/src/kudu/client/client.cc File src/kudu/client/client.cc: http://gerrit.cloudera.org:8080/#/c/18715/2/src/kudu/client/client.cc@2100 PS2, Line 2100: } else if (data_->MoreTablets()) { > Do we need to add a check for the proxy_ in this else if condition? No, we don't and shouldn't: the check for proxy_ should not be here. As one can see from the code, MoreTablets() means a new tablet should be open, and it might be hosted at completely different tablet server. -- To view, visit http://gerrit.cloudera.org:8080/18715 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icfbdfac46f35d4d143f37845d158795bf1793da7 Gerrit-Change-Number: 18715 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Khazar Mammadli <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Comment-Date: Mon, 11 Jul 2022 04:23:38 +0000 Gerrit-HasComments: Yes
