Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18714 )
Change subject: KUDU-2671 fix double-free in new scenario of scan_token-test ...................................................................... KUDU-2671 fix double-free in new scenario of scan_token-test Changelist b746978c7 introduced a bug in the updated CountRowsSeq() function -- the mistake was calling delete twice on KuduScanToken pointers. That lead to reading garbage data, so the newly introduced test scenario ScanTokensWithCustomHashSchemasPerRange was failing if enabled. I didn't pay enough attention to the updated test code when reviewing it since the new test scenario was disabled in the original patch b746978c7. This patch fixes the mistake. Change-Id: I227f1dadf9d5b4d3b209570716cde7bda74c6b25 Reviewed-on: http://gerrit.cloudera.org:8080/18714 Tested-by: Alexey Serbin <[email protected]> Reviewed-by: Khazar Mammadli <[email protected]> Reviewed-by: Mahesh Reddy <[email protected]> Reviewed-by: Abhishek Chennaka <[email protected]> Reviewed-by: Attila Bukor <[email protected]> --- M src/kudu/client/scan_token-test.cc 1 file changed, 12 insertions(+), 11 deletions(-) Approvals: Alexey Serbin: Verified Khazar Mammadli: Looks good to me, but someone else must approve Mahesh Reddy: Looks good to me, but someone else must approve Abhishek Chennaka: Looks good to me, but someone else must approve Attila Bukor: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/18714 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I227f1dadf9d5b4d3b209570716cde7bda74c6b25 Gerrit-Change-Number: 18714 Gerrit-PatchSet: 3 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Khazar Mammadli <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]>
