Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18724 )
Change subject: [refactor] Fix some lint and tidy error ...................................................................... Patch Set 1: Code-Review+1 (12 comments) http://gerrit.cloudera.org:8080/#/c/18724/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/18724/1//COMMIT_MSG@7 PS1, Line 7: error nit: errors http://gerrit.cloudera.org:8080/#/c/18724/1//COMMIT_MSG@11 PS1, Line 11: aim nit: aiming http://gerrit.cloudera.org:8080/#/c/18724/1/src/kudu/common/row_changelist.cc File src/kudu/common/row_changelist.cc: http://gerrit.cloudera.org:8080/#/c/18724/1/src/kudu/common/row_changelist.cc@268 PS1, Line 268: * style nit for here and the corresponding .h file: stick the asterisk to the type http://gerrit.cloudera.org:8080/#/c/18724/1/src/kudu/tablet/delta_applier.h File src/kudu/tablet/delta_applier.h: http://gerrit.cloudera.org:8080/#/c/18724/1/src/kudu/tablet/delta_applier.h@54 PS1, Line 54: * style nit (since you updating this code): stick the asterisk to the type, not to the variable http://gerrit.cloudera.org:8080/#/c/18724/1/src/kudu/tablet/delta_applier.h@55 PS1, Line 55: * style nit (since you updating this code): stick the asterisk to the type http://gerrit.cloudera.org:8080/#/c/18724/1/src/kudu/tablet/delta_applier.h@63 PS1, Line 63: & style nit (since you updating this code): stick the ampersand to the type http://gerrit.cloudera.org:8080/#/c/18724/1/src/kudu/tablet/delta_applier.h@70 PS1, Line 70: * style nit (since you updating this code): stick the asterisk to the type, not to the variable http://gerrit.cloudera.org:8080/#/c/18724/1/src/kudu/tablet/delta_applier.h@72 PS1, Line 72: * style nit (since you updating this code): stick the asterisk to the type http://gerrit.cloudera.org:8080/#/c/18724/1/src/kudu/tablet/delta_applier.cc File src/kudu/tablet/delta_applier.cc: http://gerrit.cloudera.org:8080/#/c/18724/1/src/kudu/tablet/delta_applier.cc@58 PS1, Line 58: * style nit (since you updating this code): stick the asterisk to the type http://gerrit.cloudera.org:8080/#/c/18724/1/src/kudu/tablet/delta_applier.cc@87 PS1, Line 87: * style nit (since you updating this code): stick the asterisk to the type http://gerrit.cloudera.org:8080/#/c/18724/1/src/kudu/tablet/delta_applier.cc@109 PS1, Line 109: * style nit (since you updating this code): stick the asterisk to the type http://gerrit.cloudera.org:8080/#/c/18724/1/src/kudu/tablet/delta_applier.cc@132 PS1, Line 132: * style nit (since you updating this code): stick the asterisk to the type -- To view, visit http://gerrit.cloudera.org:8080/18724 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I89b0f3b9ace02f380ce1193bc1facf2aaf135096 Gerrit-Change-Number: 18724 Gerrit-PatchSet: 1 Gerrit-Owner: Yingchun Lai <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Wed, 13 Jul 2022 18:44:55 +0000 Gerrit-HasComments: Yes
