Yifan Zhang has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18756 )
Change subject: [tserver] add TabletServerTest.InvalidScanRequestNoGreaterKey ...................................................................... [tserver] add TabletServerTest.InvalidScanRequestNoGreaterKey This patch adds a new test scenario into TabletServerTest to cover the case when client sends INT32_MAX value in last_primary_key with ScanRequestPB::new_scan_request field. That's to verify that tablet server sends back an error with TabletServerErrorPB::INVALID_SCAN_SPEC code. I also updated log message in TabletServiceImpl::Scan() to output information about scanner identifier upon an error setting up scanner for a scan request. In addition, I took the liberty to update the code around, getting rid of unused variables and making it more style guide compliant. Change-Id: I0992997e82114142e7f93c7898491b08208e1823 Reviewed-on: http://gerrit.cloudera.org:8080/18756 Tested-by: Kudu Jenkins Reviewed-by: Yifan Zhang <[email protected]> --- M src/kudu/tserver/tablet_server-test.cc M src/kudu/tserver/tablet_service.cc 2 files changed, 31 insertions(+), 12 deletions(-) Approvals: Kudu Jenkins: Verified Yifan Zhang: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/18756 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I0992997e82114142e7f93c7898491b08208e1823 Gerrit-Change-Number: 18756 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]>
