Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18765 )
Change subject: [client] KUDU-2671 move KuduRangePartition out of KuduTableCreator ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/18765/1/src/kudu/client/scan_token-test.cc File src/kudu/client/scan_token-test.cc: http://gerrit.cloudera.org:8080/#/c/18765/1/src/kudu/client/scan_token-test.cc@a607 PS1, Line 607: > That makes sense, just thought if we add "using" for it, then it would be m Right, but now it's out of KuduTableCreator and it's just 'KuduRangePartition' not 'KuduTableCreator::KuduRangePartition'. And this is the base version of the patch, not the updated one. But I suspect I'm missing something regarding your suggetion about "using". Maybe, you could add an example of the code that you think we should have when adding "using"? Thanks! -- To view, visit http://gerrit.cloudera.org:8080/18765 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5af14e7e802baca496e13e05860d66685914dd29 Gerrit-Change-Number: 18765 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Comment-Date: Thu, 21 Jul 2022 20:12:17 +0000 Gerrit-HasComments: Yes
