Mahesh Reddy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18753 )
Change subject: KUDU-2671: Backup/restore for custom hash schema ...................................................................... Patch Set 5: (4 comments) http://gerrit.cloudera.org:8080/#/c/18753/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/18753/2//COMMIT_MSG@7 PS2, Line 7: KUDU-2671: Backup/restore for custom hash schema > It would help if this commit message outlines what's been done in the conte Done http://gerrit.cloudera.org:8080/#/c/18753/3/java/kudu-backup-common/src/main/protobuf/backup.proto File java/kudu-backup-common/src/main/protobuf/backup.proto: http://gerrit.cloudera.org:8080/#/c/18753/3/java/kudu-backup-common/src/main/protobuf/backup.proto@94 PS3, Line 94: RangeAndHashPartitionMetadataPB { > nit: PartitionXPartition looks a bit long, how about renaming this into Ran Done http://gerrit.cloudera.org:8080/#/c/18753/3/java/kudu-backup-common/src/main/protobuf/backup.proto@96 PS3, Line 96: hash_partitions > nit: we used to call structures like this 'hash_schema' in other protobuf f Other instances in this protobuf file call it 'hash_partitions' so I just kept it consistent with that. http://gerrit.cloudera.org:8080/#/c/18753/4/java/kudu-backup-common/src/main/scala/org/apache/kudu/backup/TableMetadata.scala File java/kudu-backup-common/src/main/scala/org/apache/kudu/backup/TableMetadata.scala: http://gerrit.cloudera.org:8080/#/c/18753/4/java/kudu-backup-common/src/main/scala/org/apache/kudu/backup/TableMetadata.scala@405 PS4, Line 405: rangesWithHashSchem > nit: is this actually a collection/list? Then maybe name it 'rangesWithHas Done -- To view, visit http://gerrit.cloudera.org:8080/18753 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7b8e0481e4e9bc0ac0e5fcbf085976325dd55b0d Gerrit-Change-Number: 18753 Gerrit-PatchSet: 5 Gerrit-Owner: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Comment-Date: Fri, 22 Jul 2022 21:00:26 +0000 Gerrit-HasComments: Yes
