Marton Greber has posted comments on this change. ( http://gerrit.cloudera.org:8080/16768 )
Change subject: [thirdparty] Upgrade to LLVM 11 and IWYU 0.15 ...................................................................... Patch Set 14: > (2 comments) Good catch! When I started to work on the M1 fix, I wanted to make the llvm, the glog and other necessary patches work on their own. Later I saw that on their own its hard to get a successful build. So I went for a big squashed commit. In the beginning I pushed updates to the various patches, to see how upstream infra works. The change you pointed out is one leftover example, obviously not ment for leaving that in. I went through the glog, llvm etc patches and reverted my experimental updates, to avoid confusion. -- To view, visit http://gerrit.cloudera.org:8080/16768 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id9c32abe256978158617a4fe3a3c34e9bfd00fb2 Gerrit-Change-Number: 16768 Gerrit-PatchSet: 14 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Comment-Date: Sat, 23 Jul 2022 08:19:54 +0000 Gerrit-HasComments: No
