Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17917 )
Change subject: KUDU-3326 [delete]: Add soft delete table supports ...................................................................... Patch Set 70: (1 comment) http://gerrit.cloudera.org:8080/#/c/17917/70/src/kudu/master/catalog_manager.cc File src/kudu/master/catalog_manager.cc: http://gerrit.cloudera.org:8080/#/c/17917/70/src/kudu/master/catalog_manager.cc@2390 PS70, Line 2390: is_soft_deleted_table && !req.force_on_soft_deleted_table() > I'm still trying to understand (without much success, though): what does th I meant I understood that 'force_on_soft_deleted_table' allows to reject requests to purge soft-deleted tables unless the field is set, but why to require that? Why not just treat req.reserve_seconds() == 0 as a request to purge the table immediately, regardless whether its soft-deleted or not? Is there any specific use case you are trying to satisfy with rejecting a request to purge a soft-delete table when req.reserve_seconds() == 0 if 'force_on_soft_deleted_table' is not set to 'true' as well? Thanks! -- To view, visit http://gerrit.cloudera.org:8080/17917 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3d1dddfbca55a5c4bcac4028157325ad618ea665 Gerrit-Change-Number: 17917 Gerrit-PatchSet: 70 Gerrit-Owner: KeDeng <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: KeDeng <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Sun, 24 Jul 2022 01:11:30 +0000 Gerrit-HasComments: Yes
