Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/18742 )
Change subject: KUDU-3353 [schema] Add an immutable attribute on column schema (part 1) ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/18742/2/src/kudu/consensus/log-test.cc File src/kudu/consensus/log-test.cc: http://gerrit.cloudera.org:8080/#/c/18742/2/src/kudu/consensus/log-test.cc@1076 PS2, Line 1076: 337 > Why is this change? Because I added a new field 'optional bool immutable = 13 [default = false]' to ColumnSchemaPB, and log segment has a LogSegmentHeaderPB which caontains SchemaPB, and the later is: message SchemaPB { repeated ColumnSchemaPB columns = 1; } In log-test, it use 'GetSimpleTestSchema', the schema is: return Schema({ ColumnSchema("key", INT32), ColumnSchema("int_val", INT32), ColumnSchema("string_val", STRING, true) }, 1); It increased the kSegmentSizeBytes. -- To view, visit http://gerrit.cloudera.org:8080/18742 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I01e5a806c0e873239b49e6d0b37a7e36578b508d Gerrit-Change-Number: 18742 Gerrit-PatchSet: 4 Gerrit-Owner: Yingchun Lai <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Fri, 29 Jul 2022 18:10:47 +0000 Gerrit-HasComments: Yes
