Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/18709 )
Change subject: KUDU-3371 [fs] make LogBlockManager as a base class to be more extendable ...................................................................... Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/18709/1/src/kudu/fs/log_block_manager.h File src/kudu/fs/log_block_manager.h: http://gerrit.cloudera.org:8080/#/c/18709/1/src/kudu/fs/log_block_manager.h@188 PS1, Line 188: ~LogBlockManager() override; > warning: prefer using 'override' or (rarely) 'final' instead of 'virtual' [ Done http://gerrit.cloudera.org:8080/#/c/18709/1/src/kudu/fs/log_block_manager.h@190 PS1, Line 190: Status Open(FsReport* report, std::atomic<int>* containers_processed, > warning: default arguments on virtual or override methods are prohibited [g Done -- To view, visit http://gerrit.cloudera.org:8080/18709 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I59c1287a9539668e0c08036452bb96a3006ed356 Gerrit-Change-Number: 18709 Gerrit-PatchSet: 4 Gerrit-Owner: Yingchun Lai <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Sat, 30 Jul 2022 07:52:40 +0000 Gerrit-HasComments: Yes
