Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18797 )
Change subject: [tool] Add gflag to control the display of hash info when show partition info. ...................................................................... Patch Set 4: Code-Review+2 (2 comments) http://gerrit.cloudera.org:8080/#/c/18797/2/src/kudu/common/partition-test.cc File src/kudu/common/partition-test.cc: http://gerrit.cloudera.org:8080/#/c/18797/2/src/kudu/common/partition-test.cc@576 PS2, Line 576: EXPECT_EQ("HASH (a) PARTITION 0, HASH (b) PARTITION 0, " : R"(RANGE (a, b, c) PARTITION VALUES < ("a1", "b1", "c1"))", : partition_schema.PartitionDebugString(partitions[0], schema)); > I just want to make sure that the output is correct without hash partition. I was curious whether these particular lines were substantially different from the others where you added tests for the output of PartitionDebugString(). OK, I guess that's enough to have just the rest of partitions covered since it's a lot of coverage already. http://gerrit.cloudera.org:8080/#/c/18797/2/src/kudu/common/partition.h File src/kudu/common/partition.h: http://gerrit.cloudera.org:8080/#/c/18797/2/src/kudu/common/partition.h@390 PS2, Line 390: > Done Thank you! -- To view, visit http://gerrit.cloudera.org:8080/18797 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8bba23740a8544ea40360b70e394c31d500f81c1 Gerrit-Change-Number: 18797 Gerrit-PatchSet: 4 Gerrit-Owner: KeDeng <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: KeDeng <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Wed, 03 Aug 2022 04:36:01 +0000 Gerrit-HasComments: Yes
