Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18814 )
Change subject: KUDU-2671 range-specific hash schemas for 'kudu table add_range_partition' ...................................................................... Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/18814/1/src/kudu/tools/tool_action_table.cc File src/kudu/tools/tool_action_table.cc: http://gerrit.cloudera.org:8080/#/c/18814/1/src/kudu/tools/tool_action_table.cc@156 PS1, Line 156: JSON " > Would it be valuable to add an example? That's a good point! Done. http://gerrit.cloudera.org:8080/#/c/18814/1/src/kudu/tools/tool_action_table.cc@1031 PS1, Line 1031: if (hash_schema_str.empty()) { > warning: 4th function call argument is an uninitialized value [clang-analyz That's a bogus warning: the argument is initialized at line 1013 http://gerrit.cloudera.org:8080/#/c/18814/1/src/kudu/tools/tool_action_table.cc@1031 PS1, Line 1031: if (hash_schema_str.empty()) { > warning: 3rd function call argument is an uninitialized value [clang-analyz That's a bogus warning: the argument is initialized at line 1009 -- To view, visit http://gerrit.cloudera.org:8080/18814 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3832312b6ebfb397bb3083931f6d53039afc5e9b Gerrit-Change-Number: 18814 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Thu, 04 Aug 2022 17:38:41 +0000 Gerrit-HasComments: Yes
