Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/17917 )
Change subject: KUDU-3326 [delete]: Add soft delete table supports ...................................................................... Patch Set 78: (4 comments) http://gerrit.cloudera.org:8080/#/c/17917/76/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java File java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java: http://gerrit.cloudera.org:8080/#/c/17917/76/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java@398 PS76, Line 398: > Where is this variable used? Seems the parameter is passed manually every t Done http://gerrit.cloudera.org:8080/#/c/17917/78/java/kudu-client/src/main/java/org/apache/kudu/client/KuduClient.java File java/kudu-client/src/main/java/org/apache/kudu/client/KuduClient.java: http://gerrit.cloudera.org:8080/#/c/17917/78/java/kudu-client/src/main/java/org/apache/kudu/client/KuduClient.java@177 PS78, Line 177: for 7 days nit: reserveSeconds http://gerrit.cloudera.org:8080/#/c/17917/78/src/kudu/master/catalog_manager.cc File src/kudu/master/catalog_manager.cc: http://gerrit.cloudera.org:8080/#/c/17917/78/src/kudu/master/catalog_manager.cc@6703 PS78, Line 6703: const string table_name = table->table_name(); missing to move it out of the lock? http://gerrit.cloudera.org:8080/#/c/17917/75/src/kudu/master/master.cc File src/kudu/master/master.cc: http://gerrit.cloudera.org:8080/#/c/17917/75/src/kudu/master/master.cc@290 PS75, Line 290: > Done I meant we can validate the configs when bootstrap, e.g. check --hive_metastore_uris and some soft delete switch flag (seems there isn't such a flag currently) by GROUP_FLAG_VALIDATOR when Kudu master bootstrap, if they are both turned on, reject to boostrap. -- To view, visit http://gerrit.cloudera.org:8080/17917 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3d1dddfbca55a5c4bcac4028157325ad618ea665 Gerrit-Change-Number: 17917 Gerrit-PatchSet: 78 Gerrit-Owner: KeDeng <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: KeDeng <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Tue, 09 Aug 2022 12:50:23 +0000 Gerrit-HasComments: Yes
