Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/18742 )
Change subject: KUDU-3353 [schema] Add an immutable attribute on column schema (part 1) ...................................................................... Patch Set 9: (1 comment) http://gerrit.cloudera.org:8080/#/c/18742/7/src/kudu/tablet/tablet-test.cc File src/kudu/tablet/tablet-test.cc: http://gerrit.cloudera.org:8080/#/c/18742/7/src/kudu/tablet/tablet-test.cc@942 PS7, Line 942: TYPED_TEST(TestImmutableColumn, TestUpsert) { > Good idea! Done I found it can't be implemented, because 'upsert_ignore_errors' is updated in real client wite path, here we use LocalTabletWriter to write data, it is write directly in server internally, which will not bypass client path, we can't do that. We can check the metrics in patches when implement the client side. -- To view, visit http://gerrit.cloudera.org:8080/18742 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I01e5a806c0e873239b49e6d0b37a7e36578b508d Gerrit-Change-Number: 18742 Gerrit-PatchSet: 9 Gerrit-Owner: Yingchun Lai <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Wed, 10 Aug 2022 17:02:40 +0000 Gerrit-HasComments: Yes
