Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/18733 )
Change subject: KUDU-3306: fix PartitionSchema::DecodeRangeKey ...................................................................... Patch Set 5: (6 comments) http://gerrit.cloudera.org:8080/#/c/18733/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/18733/3//COMMIT_MSG@10 PS3, Line 10: lead > nit: lead Done http://gerrit.cloudera.org:8080/#/c/18733/3//COMMIT_MSG@11 PS3, Line 11: string > nit: string, binary, and varchar Done http://gerrit.cloudera.org:8080/#/c/18733/3/src/kudu/tools/kudu-tool-test.cc File src/kudu/tools/kudu-tool-test.cc: http://gerrit.cloudera.org:8080/#/c/18733/3/src/kudu/tools/kudu-tool-test.cc@815 PS3, Line 815: its > nit: its Done http://gerrit.cloudera.org:8080/#/c/18733/3/src/kudu/tools/kudu-tool-test.cc@1086 PS3, Line 1086: first_lower_bound > nit: first_lower_bound Done http://gerrit.cloudera.org:8080/#/c/18733/3/src/kudu/tools/kudu-tool-test.cc@1087 PS3, Line 1087: first_upper_bound > nit: first_upper_bound Done http://gerrit.cloudera.org:8080/#/c/18733/3/src/kudu/tools/kudu-tool-test.cc@1097 PS3, Line 1097: return table_creator->table_name(kTableName) : .schema(schema) : .set_range_partition_columns({"string_key"}) : .add_range_partition( : first_lower_bound.release(), first_upper_bound.release(), bound_type, bound_type) : .add_range_partition( : second_lower_bound.release(), second_upper_bound.release(), bound_type, bound_type) : .num_replicas(1) : .Create() : } : > nit: could be just Done -- To view, visit http://gerrit.cloudera.org:8080/18733 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5abf7ff9713ee391199c47710ccd81db8b97653e Gerrit-Change-Number: 18733 Gerrit-PatchSet: 5 Gerrit-Owner: Yifan Zhang <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Comment-Date: Fri, 12 Aug 2022 02:51:58 +0000 Gerrit-HasComments: Yes
