Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/18835 )
Change subject: KUDU-3353 [schema] Add an immutable attribute on column schema (part 2) ...................................................................... Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/18835/4/src/kudu/tablet/tablet.cc File src/kudu/tablet/tablet.cc: http://gerrit.cloudera.org:8080/#/c/18835/4/src/kudu/tablet/tablet.cc@a746 PS4, Line 746: ApplyUpsertAsUpdate will not return Immutable status when op is UPSERT_IGNORE, so I removed it. http://gerrit.cloudera.org:8080/#/c/18835/4/src/kudu/tablet/tablet.cc@865 PS4, Line 865: upsert->error_ignored = true; error_ignored should be set at once when find it attempt to update immutable column. -- To view, visit http://gerrit.cloudera.org:8080/18835 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id301e313eedd9cc3a494d6b4f3c14fbabe63b436 Gerrit-Change-Number: 18835 Gerrit-PatchSet: 4 Gerrit-Owner: Yingchun Lai <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Sat, 13 Aug 2022 07:39:04 +0000 Gerrit-HasComments: Yes
