Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18871 )
Change subject: [cmake] fail early if cannot find linker ...................................................................... [cmake] fail early if cannot find linker This patch switches from SEND_ERROR to FATAL_ERROR mode for the linker detection issues, so cmake doesn't continue with the processing, instead stopping and reporting on the error right away [1]. I think the updated behavior makes more sense: while addressing recent build issues on macOS, I spent some time digging into krb5-related error reported by cmake later on, but it turned that the culprit was the issue with finding a proper linker. It would save me some time if I turned my attention to the linker-related error from the very beginning. In addition, this patch removes the "Linker not found" status message that might be confusing if the GET_LINKER_VERSION function runs for multiple linker candidates (as of now, that's so at least for Linux). [1] https://cmake.org/cmake/help/latest/command/message.html Change-Id: I78c811acc7813de1c5d15a6a131b9749a76bf271 Reviewed-on: http://gerrit.cloudera.org:8080/18871 Tested-by: Kudu Jenkins Reviewed-by: Yingchun Lai <[email protected]> Reviewed-by: Attila Bukor <[email protected]> --- M cmake_modules/KuduLinker.cmake 1 file changed, 1 insertion(+), 3 deletions(-) Approvals: Kudu Jenkins: Verified Yingchun Lai: Looks good to me, but someone else must approve Attila Bukor: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/18871 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I78c811acc7813de1c5d15a6a131b9749a76bf271 Gerrit-Change-Number: 18871 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]>
