Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18870 )
Change subject: KUDU-3392 Support trusting custom certificates ...................................................................... Patch Set 4: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/18870/2/src/kudu/server/webserver-test.cc File src/kudu/server/webserver-test.cc: http://gerrit.cloudera.org:8080/#/c/18870/2/src/kudu/server/webserver-test.cc@417 PS2, Line 417: ASSERT_STR_CONTAINS(buf_.ToS Yep, this seems a good one me. As for the test coverage for set_verify_peer(false) case, we do still coverage in WebserverCrawlITest.TestAllWebPages where the TLS certification verification is disabled. Thanks for adding the coverage for the newly introducing functionality! -- To view, visit http://gerrit.cloudera.org:8080/18870 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib5a69ba54ad9c0029b83417bdb4dca65b6313005 Gerrit-Change-Number: 18870 Gerrit-PatchSet: 4 Gerrit-Owner: Attila Bukor <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Comment-Date: Tue, 23 Aug 2022 19:13:11 +0000 Gerrit-HasComments: Yes
