Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/18924 )
Change subject: [bootstrap] Reduce the memory size consumed when bootstrap ...................................................................... Patch Set 4: (10 comments) http://gerrit.cloudera.org:8080/#/c/18924/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/18924/3//COMMIT_MSG@9 PS3, Line 9: bootstrap > bootstraps Done http://gerrit.cloudera.org:8080/#/c/18924/3//COMMIT_MSG@9 PS3, Line 9: loads al > loads Done http://gerrit.cloudera.org:8080/#/c/18924/3//COMMIT_MSG@10 PS3, Line 10: as seen > it has seen Done http://gerrit.cloudera.org:8080/#/c/18924/3//COMMIT_MSG@10 PS3, Line 10: finds out > finds Done http://gerrit.cloudera.org:8080/#/c/18924/3//COMMIT_MSG@12 PS3, Line 12: contain > contain Done http://gerrit.cloudera.org:8080/#/c/18924/3//COMMIT_MSG@13 PS3, Line 13: consumes a l > consumes Done http://gerrit.cloudera.org:8080/#/c/18924/3//COMMIT_MSG@15 PS3, Line 15: : This patch optimizes the tablet bootstrap to find the : maximu > This patch optimizes the tablet bootstrap to find the maximum block id for Done http://gerrit.cloudera.org:8080/#/c/18924/3/src/kudu/tablet/rowset_metadata.cc File src/kudu/tablet/rowset_metadata.cc: http://gerrit.cloudera.org:8080/#/c/18924/3/src/kudu/tablet/rowset_metadata.cc@302 PS3, Line 302: BlockIdContainer blocks; > nit: since you have touched this code, would you mind adding 'blocks.reserv Done http://gerrit.cloudera.org:8080/#/c/18924/3/src/kudu/tablet/tablet_metadata-test.cc File src/kudu/tablet/tablet_metadata-test.cc: http://gerrit.cloudera.org:8080/#/c/18924/3/src/kudu/tablet/tablet_metadata-test.cc@248 PS3, Line 248: TabletMetadata::kNoMrsFlushed)); > Wrap this into ASSERT_OK()? Done http://gerrit.cloudera.org:8080/#/c/18924/3/src/kudu/tablet/tablet_metadata-test.cc@253 PS3, Line 253: const auto expected_max_block_id = std::max_element(block_ids.begin(), block_ids.end()); : ASSERT_EQ(*expected_max_block_id, max_block_id); : } : > nit: is it possible to add a copy/move constructor for BlockId() and shorte Good idea! Done If using std::max_element instead of std::max, it's not needed to add a copy/move constructor. -- To view, visit http://gerrit.cloudera.org:8080/18924 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If4df35f63e99a3f8331da51114991515ea4ee496 Gerrit-Change-Number: 18924 Gerrit-PatchSet: 4 Gerrit-Owner: Yingchun Lai <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Tue, 30 Aug 2022 05:53:25 +0000 Gerrit-HasComments: Yes
