Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/18923 )
Change subject: [master] KUDU-3389 support turning on/off auto rebalancer at runtime ...................................................................... Patch Set 1: Code-Review+1 (2 comments) http://gerrit.cloudera.org:8080/#/c/18923/1/src/kudu/master/auto_rebalancer.cc File src/kudu/master/auto_rebalancer.cc: http://gerrit.cloudera.org:8080/#/c/18923/1/src/kudu/master/auto_rebalancer.cc@139 PS1, Line 139: auto_rebalancing_enabled nit: Could you also add a 'runtime' tag for this flag? http://gerrit.cloudera.org:8080/#/c/18923/1/src/kudu/master/auto_rebalancer.cc@198 PS1, Line 198: } nit: With this change, seems we can only stop running rebalance task in the next loop. If some replica moves have been scheduled or are not finished, we can't stop them immediately. Maybe it's worth describing more about its real-time turning on/off. -- To view, visit http://gerrit.cloudera.org:8080/18923 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0ecee5d8b0b2344c3ad190548526ed6a2551cfdb Gerrit-Change-Number: 18923 Gerrit-PatchSet: 1 Gerrit-Owner: Yuqi Du <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Comment-Date: Tue, 30 Aug 2022 08:16:22 +0000 Gerrit-HasComments: Yes
