Yuqi Du has posted comments on this change. ( http://gerrit.cloudera.org:8080/18867 )
Change subject: [threadpool] Fix a coredump bug when shutdown SchedulerThread ...................................................................... Patch Set 8: (5 comments) According to your advices, I have fixed them. Thanks for your crs and time. You can review again. http://gerrit.cloudera.org:8080/#/c/18867/7//COMMIT_MSG Commit Message: PS7: > Please make the commit description to conform with the guidelines at https: I have read the docs several times and not very clear to your means. The error is a line words too long? I think you can directly point out errors that should fix. http://gerrit.cloudera.org:8080/#/c/18867/7//COMMIT_MSG@7 PS7, Line 7: oredump > What's extreme here? Fixed the title. http://gerrit.cloudera.org:8080/#/c/18867/7/src/kudu/util/threadpool-test.cc File src/kudu/util/threadpool-test.cc: http://gerrit.cloudera.org:8080/#/c/18867/7/src/kudu/util/threadpool-test.cc@186 PS7, Line 186: eStatement > What's 'extreme'? Fixed the name. http://gerrit.cloudera.org:8080/#/c/18867/7/src/kudu/util/threadpool-test.cc@187 PS7, Line 187: time_t current_time = time(nullptr); > What is this for? remote it. http://gerrit.cloudera.org:8080/#/c/18867/7/src/kudu/util/threadpool-test.cc@202 PS7, Line 202: me(nullptr); > Why to expect Status::IllegalState() here? Please add a comment to clarify Done -- To view, visit http://gerrit.cloudera.org:8080/18867 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I021422f7e51e1007c5bdbc877ab445f70ba12357 Gerrit-Change-Number: 18867 Gerrit-PatchSet: 8 Gerrit-Owner: Yuqi Du <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Reviewer: Yuqi Du <[email protected]> Gerrit-Comment-Date: Thu, 01 Sep 2022 03:14:30 +0000 Gerrit-HasComments: Yes
