Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18922 )
Change subject: [thirdparty] update googletest up to 1.12.1 version ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/18922/3/thirdparty/download-thirdparty.sh File thirdparty/download-thirdparty.sh: http://gerrit.cloudera.org:8080/#/c/18922/3/thirdparty/download-thirdparty.sh@181 PS3, Line 181: GMOCK_PATCHLEVEL=2 > does this need to be patch level 2 if we have a new GMOCK_VERSION? Good point -- it's enough to start from scratch since the patch level files are in the directory where the sources are unpacked, and that's versioned. I updated the patchlevel. -- To view, visit http://gerrit.cloudera.org:8080/18922 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic1a398cbb93a6edb918e84e05927feb4b067058c Gerrit-Change-Number: 18922 Gerrit-PatchSet: 3 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Thu, 01 Sep 2022 15:28:48 +0000 Gerrit-HasComments: Yes
