Yifan Zhang has posted comments on this change. (
http://gerrit.cloudera.org:8080/18972 )
Change subject: [gutil] remove unused code from walltime.{h,cc}
......................................................................
Patch Set 1: Code-Review+2
> Patch Set 1:
>
> > There's still a Tidy warning need to address.
>
> Well, that code has been imported from the supersonic project a long time
> ago: https://github.com/google/supersonic
>
> I'd rather leave it 'as is' in this patch, removing only parts that are
> getting bitrot. If it makes sense to you, I can work on changes in
> StringAppendStrftime() as a part of separate patch.
Got it. It's OK to keep it as it is.
--
To view, visit http://gerrit.cloudera.org:8080/18972
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ieddb6d34c047450f4e5cf445d290e965580c4ed5
Gerrit-Change-Number: 18972
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Yifan Zhang <[email protected]>
Gerrit-Comment-Date: Wed, 14 Sep 2022 03:00:10 +0000
Gerrit-HasComments: No
