Alexey Serbin has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/18967 )

Change subject: [tests] fix flakiness in TestFailDuringScanWorkload
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/18967/2/src/kudu/integration-tests/disk_failure-itest.cc
File src/kudu/integration-tests/disk_failure-itest.cc:

http://gerrit.cloudera.org:8080/#/c/18967/2/src/kudu/integration-tests/disk_failure-itest.cc@397
PS2, Line 397: So, at least one tablet replica
             :   // is about to be marked as failed at 'error_ts' as a result
> nit: Maybe we can wait for 'ts->num_raft_leaders() >= 1' here?
That's a good idea.  Done.



--
To view, visit http://gerrit.cloudera.org:8080/18967
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia29bfdc9761139426344532bab3e5d0b3c1b12ad
Gerrit-Change-Number: 18967
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yifan Zhang <[email protected]>
Gerrit-Comment-Date: Wed, 14 Sep 2022 18:26:11 +0000
Gerrit-HasComments: Yes

Reply via email to