Alexey Serbin has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/18866 )

Change subject: [master] KUDU-3322 / KUDU-3319 HMS event logging
......................................................................


Patch Set 6: Code-Review+1

(1 comment)

http://gerrit.cloudera.org:8080/#/c/18866/6/src/kudu/integration-tests/master_hms-itest.cc
File src/kudu/integration-tests/master_hms-itest.cc:

http://gerrit.cloudera.org:8080/#/c/18866/6/src/kudu/integration-tests/master_hms-itest.cc@893
PS6, Line 893: // TODO(achennaka): Skip test until server timeouts seen in ASAN 
builds are resolved.
             : #if defined(ADDRESS_SANITIZER)
             :   GTEST_SKIP();
             : #endif
It would be great to make sure ASAN tests pass: for some reason, dist-test 
could not submit the verification job: 
http://jenkins.kudu.apache.org/job/kudu-gerrit/26499/BUILD_TYPE=ASAN/console

It might be possible that ASAN still report an issue since the SetUp() runs 
before GSKIP_TEST().  Maybe, a simpler solution would be just leaving the test 
as DISABLED for a while, and then re-enabling when the issue with ASAN failure 
is resolved.



--
To view, visit http://gerrit.cloudera.org:8080/18866
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I242c9cedf170ed621867b905f1cb1875347d5887
Gerrit-Change-Number: 18866
Gerrit-PatchSet: 6
Gerrit-Owner: Abhishek Chennaka <[email protected]>
Gerrit-Reviewer: Abhishek Chennaka <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 23 Sep 2022 12:29:42 +0000
Gerrit-HasComments: Yes

Reply via email to