Khazar Mammadli has posted comments on this change. ( http://gerrit.cloudera.org:8080/19026 )
Change subject: KUDU-3401 Fix table creation with HMS Integration ...................................................................... Patch Set 5: > Thanks for following up on the fix. Did we get to the bottom of > why/how were these fields set in older versions of Kudu where this > issue wasn't encountered? In the previous versions (without HMS integration) table creation goes through Impala and the SD fields(input/outputFormat and SerializationLibrary) for the table are populated by createSd(). With the Kudu HMS Integration enabled these fields we're not getting set when creating a table, although in hive_metastore.thrift for create_table request it is stated that these fields are necessary. The tests also did not check if the SD fields we're set when asserting table contents and that's how it went under the radar for a little while. -- To view, visit http://gerrit.cloudera.org:8080/19026 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia1b53b55005e2899d8575b0fb7250351d914afb4 Gerrit-Change-Number: 19026 Gerrit-PatchSet: 5 Gerrit-Owner: Khazar Mammadli <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Khazar Mammadli <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Comment-Date: Wed, 28 Sep 2022 11:57:08 +0000 Gerrit-HasComments: No
