Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/19134 )
Change subject: [test] ASSERT_OK instead of CHECK_OK when appropriate ...................................................................... [test] ASSERT_OK instead of CHECK_OK when appropriate Recently I ran a few tests in FIPS environment, and even if those were expected to fail because our test scenarios use very short encryption keys to run faster (compared with minimum allowed encryption key size required by FIPS 140-2), I was unpleasantly surprised that some of those simply crashed instead of exiting gracefully and reporting an error. This patch addresses that for rpc-test and tls_socket-test. Change-Id: I48d9bb2def2350c11afc41b9f08fa252c7ead65a Reviewed-on: http://gerrit.cloudera.org:8080/19134 Reviewed-by: Attila Bukor <[email protected]> Tested-by: Kudu Jenkins --- M src/kudu/rpc/rpc-test.cc M src/kudu/security/tls_socket-test.cc 2 files changed, 12 insertions(+), 6 deletions(-) Approvals: Attila Bukor: Looks good to me, approved Kudu Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/19134 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I48d9bb2def2350c11afc41b9f08fa252c7ead65a Gerrit-Change-Number: 19134 Gerrit-PatchSet: 3 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120)
