Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18467 )
Change subject: util: pull jwt code from Impala ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/18467/2/src/kudu/util/jwt-util.cc File src/kudu/util/jwt-util.cc: http://gerrit.cloudera.org:8080/#/c/18467/2/src/kudu/util/jwt-util.cc@663 PS2, Line 663: if (FLAGS_jwks_update_frequency_s <= 0) { : LOG(WARNING) << "Invalid value for flag jwks_update_frequency_s: " : << FLAGS_jwks_update_frequency_s << ", use default value 60."; : FLAGS_jwks_update_frequency_s = 60; : } : if (FLAGS_jwks_pulling_timeout_s <= 0) { : LOG(WARNING) << "Invalid value for flag jwks_pulling_timeout_s: " : << FLAGS_jwks_pulling_timeout_s << ", use default value 10."; : FLAGS_jwks_pulling_timeout_s = 10; : } This is a wrong place to check -- that should be done in flag validators instead. http://gerrit.cloudera.org:8080/#/c/18467/2/src/kudu/util/jwt-util.cc@688 PS2, Line 688: if (new_jwks->IsEmpty()) LOG(WARNING) << "JWKS file is empty."; That's a bit funny to see as a warning since in other places it's considered as an error, e.g. in JWTHelper::Verify() method. -- To view, visit http://gerrit.cloudera.org:8080/18467 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib546762aa7ff53009f32688c30c5642ee4df494b Gerrit-Change-Number: 18467 Gerrit-PatchSet: 2 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Comment-Date: Wed, 19 Oct 2022 20:06:04 +0000 Gerrit-HasComments: Yes
