Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/19160 )
Change subject: [clock] remove 'unsafe' tag from --use_hybrid_clock ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/19160/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19160/2//COMMIT_MSG@10 PS2, Line 10: setting --use_hybrid_clock=true would : require adding --unlock_unsafe_flags as well Is seems all flags which have 'unsafe' tag have the same behavior, it would be better to fix it in util/flags.cc? 'is_default' [1] is not work in this case, use 'current_value' and 'default_value' to judge if it is default? 1. https://github.com/gflags/gflags/blob/master/src/gflags.h.in#L159 -- To view, visit http://gerrit.cloudera.org:8080/19160 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie93db07f58ea3a5bac03f536852d6126e1174c3b Gerrit-Change-Number: 19160 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Reviewer: Yuqi Du <[email protected]> Gerrit-Comment-Date: Sat, 22 Oct 2022 10:09:41 +0000 Gerrit-HasComments: Yes
