Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/19163 )
Change subject: [Tools][Bugfix] Fix bug of tablet copier which will cause core dump ...................................................................... Patch Set 2: Code-Review+1 (3 comments) http://gerrit.cloudera.org:8080/#/c/19163/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19163/2//COMMIT_MSG@9 PS2, Line 9: The function: CopyTablets() of class TabletCopier creates a thread to obtain copy process periodically, nit: It's too wide, it's recommend to obey the 50/72 commit message rule [1]. 1. https://git-scm.com/book/en/v2/Distributed-Git-Contributing-to-a-Project#_commit_guidelines http://gerrit.cloudera.org:8080/#/c/19163/2//COMMIT_MSG@11 PS2, Line 11: core dump Could you please create an JIRA and attach some pics/logs about it? http://gerrit.cloudera.org:8080/#/c/19163/2/src/kudu/tools/tool_action_local_replica.cc File src/kudu/tools/tool_action_local_replica.cc: http://gerrit.cloudera.org:8080/#/c/19163/2/src/kudu/tools/tool_action_local_replica.cc@35 PS2, Line 35: #include <boost/container/vector.hpp> Where use it? -- To view, visit http://gerrit.cloudera.org:8080/19163 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iaa2107d3c04c9f3e850d33dbf420ebb62edc98d8 Gerrit-Change-Number: 19163 Gerrit-PatchSet: 2 Gerrit-Owner: Wang Xixu <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Tue, 25 Oct 2022 06:35:28 +0000 Gerrit-HasComments: Yes
