Yuqi Du has posted comments on this change. ( http://gerrit.cloudera.org:8080/19047 )
Change subject: KUDU-3326 [master] add improvement on interpreting the 'reserve_seconds' field for DeleteRPC ...................................................................... Patch Set 12: (8 comments) http://gerrit.cloudera.org:8080/#/c/19047/12//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19047/12//COMMIT_MSG@10 PS12, Line 10: the a nit: a http://gerrit.cloudera.org:8080/#/c/19047/12/src/kudu/client/client-test.cc File src/kudu/client/client-test.cc: http://gerrit.cloudera.org:8080/#/c/19047/12/src/kudu/client/client-test.cc@5358 PS12, Line 5358: the nit: The http://gerrit.cloudera.org:8080/#/c/19047/12/src/kudu/client/client.cc File src/kudu/client/client.cc: http://gerrit.cloudera.org:8080/#/c/19047/12/src/kudu/client/client.cc@513 PS12, Line 513: reserve_seconds The api doesn't exist 'reserve_seconds', should comments be changed? http://gerrit.cloudera.org:8080/#/c/19047/12/src/kudu/master/catalog_manager.cc File src/kudu/master/catalog_manager.cc: http://gerrit.cloudera.org:8080/#/c/19047/12/src/kudu/master/catalog_manager.cc@2414 PS12, Line 2414: if (s.IsNotFound()) { : return DeleteTableRpc(req, resp, rpc); : } Table is not found, execute DeleteTableRpc for the table? Maybe it's triviality, but a little strange. http://gerrit.cloudera.org:8080/#/c/19047/12/src/kudu/master/catalog_manager.cc@2429 PS12, Line 2429: == 0 How about req.reserve_seconds() < 0? And two line codes above about ' < 0' . http://gerrit.cloudera.org:8080/#/c/19047/12/src/kudu/master/master.proto File src/kudu/master/master.proto: http://gerrit.cloudera.org:8080/#/c/19047/12/src/kudu/master/master.proto@589 PS12, Line 589: the a nit: a http://gerrit.cloudera.org:8080/#/c/19047/12/src/kudu/tools/tool_action_table.cc File src/kudu/tools/tool_action_table.cc: http://gerrit.cloudera.org:8080/#/c/19047/12/src/kudu/tools/tool_action_table.cc@202 PS12, Line 202: reserve_seconds reserve_time_s, soft_table_reserve_time_s ? http://gerrit.cloudera.org:8080/#/c/19047/12/src/kudu/tools/tool_action_table.cc@204 PS12, Line 204: table is purged once it dropped/deleted It would be purged when a table is dropped/deleted. -- To view, visit http://gerrit.cloudera.org:8080/19047 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I604caf5d7326e27acd6d626b482376fc6eed1b0f Gerrit-Change-Number: 19047 Gerrit-PatchSet: 12 Gerrit-Owner: KeDeng <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: KeDeng <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Reviewer: Yuqi Du <[email protected]> Gerrit-Comment-Date: Thu, 03 Nov 2022 08:22:34 +0000 Gerrit-HasComments: Yes
