Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/19209 )
Change subject: KUDU-3420[Tools] Fixbug of list local replica with parameter --list_detail ...................................................................... Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/19209/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19209/1//COMMIT_MSG@13 PS1, Line 13: See the detail #KUDU-3420 could you please leave some crash stacks in commit message, then uses can grep the commit log to check the bug conveniently, like c71f8abbbebb6e8c003090c0bb5866b443b8955f http://gerrit.cloudera.org:8080/#/c/19209/1/src/kudu/tools/kudu-tool-test.cc File src/kudu/tools/kudu-tool-test.cc: http://gerrit.cloudera.org:8080/#/c/19209/1/src/kudu/tools/kudu-tool-test.cc@2962 PS1, Line 2962: $0 --list_detail=true encryption_args should be passed as well to test encryption cases. http://gerrit.cloudera.org:8080/#/c/19209/1/src/kudu/tools/tool_action_local_replica.cc File src/kudu/tools/tool_action_local_replica.cc: http://gerrit.cloudera.org:8080/#/c/19209/1/src/kudu/tools/tool_action_local_replica.cc@933 PS1, Line 933: if (FLAGS_list_detail) { how about define a new boolean variable like: bool skip_block_manager = !FLAGS_list_detail; -- To view, visit http://gerrit.cloudera.org:8080/19209 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7d8551280ad8edd416a0dd1b9611185cabe1a5bc Gerrit-Change-Number: 19209 Gerrit-PatchSet: 1 Gerrit-Owner: Wang Xixu <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Sun, 06 Nov 2022 08:13:35 +0000 Gerrit-HasComments: Yes
