Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/18945 )
Change subject: KUDU-3393 C++ client support split a tablet to mutil ranges and concurrent scan data ...................................................................... Patch Set 12: (1 comment) http://gerrit.cloudera.org:8080/#/c/18945/8/src/kudu/client/client-test.cc File src/kudu/client/client-test.cc: http://gerrit.cloudera.org:8080/#/c/18945/8/src/kudu/client/client-test.cc@8739 PS8, Line 8739: builder.SetSplitSizeBytes(20); > With the influence of gc and other behaviors? the token nums we get may dif SetSplitSizeBytes as 20, you can insert plenty of data to make splitSizeBytes is far less than tablet size, and you can disable compact/gc by setting flag enable_maintenance_manager=false. ASSERT_NE(token_size_a, token_size_b) is not enough, if token_size_a and token_size_b are possible equal to 4, the assertion may fail. -- To view, visit http://gerrit.cloudera.org:8080/18945 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I207f9584cd558d32fcd9e8de7d6c25e517377272 Gerrit-Change-Number: 18945 Gerrit-PatchSet: 12 Gerrit-Owner: KeDeng <[email protected]> Gerrit-Reviewer: KeDeng <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Thu, 10 Nov 2022 04:13:37 +0000 Gerrit-HasComments: Yes
