Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/15145 )
Change subject: KUDU-1625: background op to GC ancient, fully deleted rowsets ...................................................................... Patch Set 10: (1 comment) http://gerrit.cloudera.org:8080/#/c/15145/10/src/kudu/tablet/tablet.cc File src/kudu/tablet/tablet.cc: http://gerrit.cloudera.org:8080/#/c/15145/10/src/kudu/tablet/tablet.cc@1481 PS10, Line 1481: if (metadata_->supports_live_row_count()) { Hi, @Andrew Even if live row count doesn't support, the DeletedRowsetGCOp will fallback to use timestamp [1], so can use enable this op? 1. https://gerrit.cloudera.org/c/15145/10/src/kudu/tablet/diskrowset.cc#888 -- To view, visit http://gerrit.cloudera.org:8080/15145 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I696e2a29ea52ad4e54801b495c322bc371787124 Gerrit-Change-Number: 15145 Gerrit-PatchSet: 10 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Adar Lieber-Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Volodymyr Verovkin <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Thu, 10 Nov 2022 13:43:22 +0000 Gerrit-HasComments: Yes
