Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/19202 )
Change subject: [c++ build] suppress deprecation warnings ...................................................................... Patch Set 1: > Overall looks good to me, just need to address the tidy warnings. Out of 3 tidy warnings, 2 are bogus -- there isn't uninitialized variables used there, actually (that's a know false-positive pattern for tidy). The third one about renaming: that rebind structure should be named as-is to match one in libstc++ headers, and I'm not sure it sense to change it unless risking to break something. -- To view, visit http://gerrit.cloudera.org:8080/19202 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I069a0680b4bc981b311374cc08bb950578db0dd0 Gerrit-Change-Number: 19202 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Comment-Date: Thu, 10 Nov 2022 18:37:17 +0000 Gerrit-HasComments: No
