Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/19244 )
Change subject: [build] mute some build complains ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/19244/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19244/1//COMMIT_MSG@14 PS1, Line 14: Using if-statement instead of ternary operator to mute warning: I don't think this helps with readability. http://gerrit.cloudera.org:8080/#/c/19244/1//COMMIT_MSG@15 PS1, Line 15: warning: ‘iftmp.3695’ may be used uninitialized in this function [-Wmaybe-uninitialized] : update_immu_col_to_null_ ? nullopt : optional<int>(999)); Apparently, this is just a bogus warning. I wouldn't bother about this since because this is just a single bogus warning, especially if it makes the code less readable and concise. -- To view, visit http://gerrit.cloudera.org:8080/19244 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I690a27d6afdad00a57587892cacc2ad245a7d342 Gerrit-Change-Number: 19244 Gerrit-PatchSet: 1 Gerrit-Owner: Yingchun Lai <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Mon, 14 Nov 2022 20:03:25 +0000 Gerrit-HasComments: Yes
