Yuqi Du has posted comments on this change. ( http://gerrit.cloudera.org:8080/19239 )
Change subject: [refactor] improve code readability by reducing if-statement levels ...................................................................... Patch Set 1: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/19239/1/src/kudu/util/net/dns_resolver.cc File src/kudu/util/net/dns_resolver.cc: http://gerrit.cloudera.org:8080/#/c/19239/1/src/kudu/util/net/dns_resolver.cc@176 PS1, Line 176: If 'addresses' can be passed as nullptr, I seems return 'false' ? or some restriction need added. -- To view, visit http://gerrit.cloudera.org:8080/19239 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I846a74e3525b0de986b95a05e8a39b476c3daa91 Gerrit-Change-Number: 19239 Gerrit-PatchSet: 1 Gerrit-Owner: Yingchun Lai <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: KeDeng <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Reviewer: Yuqi Du <[email protected]> Gerrit-Comment-Date: Tue, 15 Nov 2022 03:27:07 +0000 Gerrit-HasComments: Yes
