Yuqi Du has posted comments on this change. ( http://gerrit.cloudera.org:8080/18454 )
Change subject: [master] KUDU-3390 support auto rebalance tablet leaders across TServers ...................................................................... Patch Set 40: (2 comments) Thank you for your advices. http://gerrit.cloudera.org:8080/#/c/18454/40/src/kudu/master/auto_leader_rebalancer-test.cc File src/kudu/master/auto_leader_rebalancer-test.cc: http://gerrit.cloudera.org:8080/#/c/18454/40/src/kudu/master/auto_leader_rebalancer-test.cc@174 PS40, Line 174: TEST_F(LeaderRebalancerTest, RestartTserver) { > From what I can see, the following isn't covered by tests: the case when ma Some test cases, I have put them at 'auto_rebalancer-test.cc'. The case what you point out is in 'AutoRebalancerTest.NextLeaderResumesAutoRebalancing' http://gerrit.cloudera.org:8080/#/c/18454/40/src/kudu/master/auto_leader_rebalancer.cc File src/kudu/master/auto_leader_rebalancer.cc: http://gerrit.cloudera.org:8080/#/c/18454/40/src/kudu/master/auto_leader_rebalancer.cc@349 PS40, Line 349: MutexLock auto_lock(running_mutex_); > What is this for? RunLeaderRebalancer() is called from a single thread, so I am sorry, the lock is not necessary at this patch. One of my plans, it should be used next patch, at that patch another thread would run 'RunLeaderRebalancer()'. Sorry for that. -- To view, visit http://gerrit.cloudera.org:8080/18454 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibfb60d8759a93b6a19238637c27df4f6b1cac918 Gerrit-Change-Number: 18454 Gerrit-PatchSet: 40 Gerrit-Owner: Yuqi Du <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Reviewer: Yuqi Du <[email protected]> Gerrit-Comment-Date: Thu, 17 Nov 2022 09:50:50 +0000 Gerrit-HasComments: Yes
