Ádám Bakai has posted comments on this change. ( http://gerrit.cloudera.org:8080/19232 )
Change subject: Follow-up on OpenSSL 3 FIPS_mode removal ...................................................................... Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/19232/5/src/kudu/server/webserver-test.cc File src/kudu/server/webserver-test.cc: http://gerrit.cloudera.org:8080/#/c/19232/5/src/kudu/server/webserver-test.cc@69 PS5, Line 69: // FIPS_mode is removed from OpenSSL3 for test purposes, a fake one is created and : // set to disabled. : #if OPENSSL_VERSION_NUMBER >= 0x30000000L : int FIPS_mode() { return 0; } : #endif > Is this still required after adding corresponding if-defs in src/kudu/serve Yes they, do because in multiple tests in webserver-test.cc FIPS_mode function is still used(line 112 for example). One can argue, that one function that wraps around FIPS_mode and call it everywhere would be a better solution. It would be a little bit bigger modification in terms of number of changed lines. -- To view, visit http://gerrit.cloudera.org:8080/19232 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib67d6e6c28085ca61456c26a759c89ecdffb0b4a Gerrit-Change-Number: 19232 Gerrit-PatchSet: 5 Gerrit-Owner: Ádám Bakai <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Reviewer: Ádám Bakai <[email protected]> Gerrit-Comment-Date: Thu, 17 Nov 2022 14:16:13 +0000 Gerrit-HasComments: Yes
