Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/19253 )
Change subject: KUDU-3421 Specify the error causing CLI argument ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/19253/2/src/kudu/master/master_main.cc File src/kudu/master/master_main.cc: http://gerrit.cloudera.org:8080/#/c/19253/2/src/kudu/master/master_main.cc@36 PS2, Line 36: argv[1] > Maybe, The illegal flag is an argv after argv[1] ? The way how ParseCommandLineFlags(..., ..., true) works guarantees if first goes over all flags, and only then gets to other args. So, in case of any unrecognized flag it will report on them. For example: $ ./kudu-master unsupported_args --hello ERROR: unknown command line flag 'hello' If necessary, the details could be found at https://gflags.github.io/gflags/ -- To view, visit http://gerrit.cloudera.org:8080/19253 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4d832615d4b70718ce581ab72a27bad012d6a87f Gerrit-Change-Number: 19253 Gerrit-PatchSet: 2 Gerrit-Owner: Ádám Bakai <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yuqi Du <[email protected]> Gerrit-Comment-Date: Fri, 18 Nov 2022 19:26:38 +0000 Gerrit-HasComments: Yes
