Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/19257 )
Change subject: KUDU-3371 [thirdparty] introduce rocksdb ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/19257/2/thirdparty/vars.sh File thirdparty/vars.sh: http://gerrit.cloudera.org:8080/#/c/19257/2/thirdparty/vars.sh@280 PS2, Line 280: ROCKSDB_NAME=v$ROCKSDB_VERSION > nit: ROCKSDB_NAME = v7.7.3 doesn't explain the library name correctly It's needed to upload the package to AWS S3 [1] firstly, and rename the packsge to rocksdb-7.7.3.tar.gz. Do you have the privilege to upload it? Thanks Package download url: https://github.com/facebook/rocksdb/archive/refs/tags/v7.7.3.tar.gz 1. https://github.com/apache/kudu/blob/master/thirdparty/vars.sh#L31 -- To view, visit http://gerrit.cloudera.org:8080/19257 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I42992d080fb9e9d77ca5169615d61eb3463fa54c Gerrit-Change-Number: 19257 Gerrit-PatchSet: 2 Gerrit-Owner: Yingchun Lai <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: KeDeng <[email protected]> Gerrit-Reviewer: Khazar Mammadli <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Reviewer: Yuqi Du <[email protected]> Gerrit-Comment-Date: Tue, 22 Nov 2022 16:28:15 +0000 Gerrit-HasComments: Yes
