Zoltan Chovan has posted comments on this change. ( http://gerrit.cloudera.org:8080/19271 )
Change subject: KUDU-3423 Add support for Ranger KMS HA ...................................................................... Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/19271/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19271/2//COMMIT_MSG@10 PS2, Line 10: serves nit: servers Also, maybe add a note about the format of the list (comma separated, no spaces) here? http://gerrit.cloudera.org:8080/#/c/19271/2//COMMIT_MSG@16 PS2, Line 16: If the : server responds with an error I think this needs to be cleared up a bit. Are you referring to the first server that responds with an error? Are we giving up if the error is not network related/timeout? http://gerrit.cloudera.org:8080/#/c/19271/2/src/kudu/fs/fs_manager.cc File src/kudu/fs/fs_manager.cc: http://gerrit.cloudera.org:8080/#/c/19271/2/src/kudu/fs/fs_manager.cc@140 PS2, Line 140: URLSs nit: URLs http://gerrit.cloudera.org:8080/#/c/19271/2/src/kudu/util/curl_util.h File src/kudu/util/curl_util.h: http://gerrit.cloudera.org:8080/#/c/19271/2/src/kudu/util/curl_util.h@59 PS2, Line 59: Status FetchURL(const std::vector<std::string>& urls, maybe add a note to the comments for the multiple url variants, here and below -- To view, visit http://gerrit.cloudera.org:8080/19271 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibef941ed20eda1f4e624c2c7e16ca7955af570d8 Gerrit-Change-Number: 19271 Gerrit-PatchSet: 2 Gerrit-Owner: Attila Bukor <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Comment-Date: Wed, 23 Nov 2022 14:45:19 +0000 Gerrit-HasComments: Yes
