Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/19267 )
Change subject: KUDU-1945 [client] Add UINT64 support to cpp client ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/19267/1/src/kudu/common/partial_row.h File src/kudu/common/partial_row.h: http://gerrit.cloudera.org:8080/#/c/19267/1/src/kudu/common/partial_row.h@109 PS1, Line 109: SetSerial > If exposing the new type under Serial alias, should this be named SetSerial Done http://gerrit.cloudera.org:8080/#/c/19267/1/src/kudu/tools/tool_action_table.cc File src/kudu/tools/tool_action_table.cc: http://gerrit.cloudera.org:8080/#/c/19267/1/src/kudu/tools/tool_action_table.cc@1001 PS1, Line 1001: RETURN_NOT_OK_PREPEND( : reader.ExtractUint64(values[i], /*field=*/nullptr, &value), : error_msg); : RETURN_NOT_OK(range_bound_partial_row->SetSerial(col_name, value)); > nit: the indent is off Done -- To view, visit http://gerrit.cloudera.org:8080/19267 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I36da282f8f103d642256ea6aaadd1d052ab2f234 Gerrit-Change-Number: 19267 Gerrit-PatchSet: 2 Gerrit-Owner: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 23 Nov 2022 16:08:43 +0000 Gerrit-HasComments: Yes
