Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/19175 )
Change subject: Test RPC and session timeout independence ...................................................................... Patch Set 5: (3 comments) http://gerrit.cloudera.org:8080/#/c/19175/5/src/kudu/client/client-test.cc File src/kudu/client/client-test.cc: http://gerrit.cloudera.org:8080/#/c/19175/5/src/kudu/client/client-test.cc@936 PS5, Line 936: } > The problem is that I couldn't find any metric that works like that. It seems TotalCount() for the request latency histrogram is good enough for that, right? http://gerrit.cloudera.org:8080/#/c/19175/6/src/kudu/client/client-test.cc File src/kudu/client/client-test.cc: http://gerrit.cloudera.org:8080/#/c/19175/6/src/kudu/client/client-test.cc@915 PS6, Line 915: The rule of thumb is: a test that takes 3 seconds or more is considered slow, so it should be skipped unless KUDU_ALLOW_SLOW_TESTS environment variable is set. With that, please add SKIP_IF_SLOW_NOT_ALLOWED() in the very beginning of this test since it could run more than 10 seconds. Is it possible to reduce the timeout settings not introducing a lot of flakiness? http://gerrit.cloudera.org:8080/#/c/19175/6/src/kudu/client/client-test.cc@928 PS6, Line 928: const shared_ptr<KuduSession> session = client_->NewSession(); nit: I guess the cleanup should also call 'latch.CountDown();' before joining the threads to reduce waiting time if something failed -- To view, visit http://gerrit.cloudera.org:8080/19175 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I177f5dcf04417edff8816690765a0c2b57e44036 Gerrit-Change-Number: 19175 Gerrit-PatchSet: 5 Gerrit-Owner: Ádám Bakai <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Reviewer: Ádám Bakai <[email protected]> Gerrit-Comment-Date: Fri, 25 Nov 2022 20:30:29 +0000 Gerrit-HasComments: Yes
