Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/19277 )
Change subject: [tablet] minor optimization on DeltaFileIterator ...................................................................... Patch Set 1: Code-Review+1 (2 comments) http://gerrit.cloudera.org:8080/#/c/19277/1/src/kudu/tablet/deltafile.h File src/kudu/tablet/deltafile.h: http://gerrit.cloudera.org:8080/#/c/19277/1/src/kudu/tablet/deltafile.h@288 PS1, Line 288: scoped_refptr<cfile::BlockHandle> block_in, : const cfile::BlockPointer& block_ptr_in, nit: Switch the order of these two parameters. http://gerrit.cloudera.org:8080/#/c/19277/1/src/kudu/tablet/deltafile.h@306 PS1, Line 306: //std::unique_ptr<cfile::BinaryPlainBlockDecoder> decoder_; nit: Remove this line? -- To view, visit http://gerrit.cloudera.org:8080/19277 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia5edd08ab060074d123d1d05ec4b656be3bfc3c8 Gerrit-Change-Number: 19277 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Comment-Date: Thu, 01 Dec 2022 04:03:45 +0000 Gerrit-HasComments: Yes
