Hello Tidy Bot, Ashwani Raina, Attila Bukor, Yifan Zhang, Kudu Jenkins,
Abhishek Chennaka,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/19269
to look at the new patch set (#2).
Change subject: [tablet] a small cleanup on DeltaTracker and around
......................................................................
[tablet] a small cleanup on DeltaTracker and around
I was briefly looking at the compaction-related code and noticed a bit
of room for improvement. This patch is the result. It introduces
a bunch of minor changes to DeltaTracker and compaction-related code:
* updated DeltaTracker::Update() to accept nullptr for the
OperationResultPB output parameter
* removed per-block heap allocated instance of OperationResultPB
in ReupdateMissedDeltas()
* switched to std::atomic<bool> instead of AtomicBool for the
DeltaTracker::dms_exists_ field
* renamed delta_tracker() --> mutable_delta_tracker() for DiskRowSet
* introduced DiskRowSet::delta_tracker() to return const reference
(this is going to be used in a follow-up patch)
* updated RowSetMetadata::Commit{Redo,Undo}DeltaDataBlock() to
return 'void' instead of 'Status'
* added a few DCHECK macros to spot inconsistencies
* updated related code to be more style-compliant
Change-Id: I9e42c72664c07e126f8cce5f071db56c0b4fe48c
---
M src/kudu/cfile/cfile_writer.cc
M src/kudu/cfile/cfile_writer.h
M src/kudu/tablet/compaction.cc
M src/kudu/tablet/delta_store.cc
M src/kudu/tablet/delta_tracker.cc
M src/kudu/tablet/delta_tracker.h
M src/kudu/tablet/diskrowset-test.cc
M src/kudu/tablet/diskrowset.cc
M src/kudu/tablet/diskrowset.h
M src/kudu/tablet/metadata-test.cc
M src/kudu/tablet/rowset_metadata.cc
M src/kudu/tablet/rowset_metadata.h
M src/kudu/tablet/tablet.cc
13 files changed, 86 insertions(+), 81 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/69/19269/2
--
To view, visit http://gerrit.cloudera.org:8080/19269
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I9e42c72664c07e126f8cce5f071db56c0b4fe48c
Gerrit-Change-Number: 19269
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Abhishek Chennaka <[email protected]>
Gerrit-Reviewer: Ashwani Raina <[email protected]>
Gerrit-Reviewer: Attila Bukor <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Yifan Zhang <[email protected]>
